-
Notifications
You must be signed in to change notification settings - Fork 254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(NODE-5957): add BSON indexing API #654
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbbeeken
force-pushed
the
NODE-5957-parse-to-elements
branch
3 times, most recently
from
March 4, 2024 20:51
ffb41a1
to
290b9ce
Compare
nbbeeken
force-pushed
the
NODE-5957-parse-to-elements
branch
from
March 4, 2024 20:51
290b9ce
to
05ad18c
Compare
nbbeeken
changed the title
feat(NODE-5957): add parse to elements API
feat(NODE-5957): add BSON indexing API
Mar 5, 2024
W-A-James
added
the
Primary Review
In Review with primary reviewer, not yet ready for team's eyes
label
Mar 5, 2024
W-A-James
requested changes
Mar 5, 2024
W-A-James
previously approved these changes
Mar 6, 2024
W-A-James
added
Team Review
Needs review from team
and removed
Primary Review
In Review with primary reviewer, not yet ready for team's eyes
labels
Mar 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, left a few clarifying comments
baileympearson
previously requested changes
Mar 6, 2024
W-A-James
reviewed
Mar 7, 2024
W-A-James
previously approved these changes
Mar 7, 2024
aditi-khare-mongoDB
approved these changes
Mar 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
W-A-James
approved these changes
Mar 7, 2024
W-A-James
dismissed
baileympearson’s stale review
March 7, 2024 22:57
Concerns addressed and go-ahead to merge given via slack
This was referenced May 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is changing?
Algorithm
Is there new documentation needed for these changes?
There is TS doc marking the new APIs as
@experimental
What is the motivation for this change?
This API is intended to be a building block for unlocking optimizations around lazily parsing BSON.
Double check the following
npm run check:lint
scripttype(NODE-xxxx)[!]: description
feat(NODE-1234)!: rewriting everything in coffeescript