-
Notifications
You must be signed in to change notification settings - Fork 254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(NODE-5506): add Binary subtype sensitive #657
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pretty much lgtm, just a few more bits: Can we also add to the static constants we have on the Binary class? and tests that match what we did with the last new constant?
Also "See release highlights." but there are none, this is a feat so it should have something, I'd say nothing more than the new constant on the Binary class and what it refers to.
git push
Co-authored-by: Neal Beeken <[email protected]>
Description
New
BSON.Binary
subtype 0x08sensitive
is introduced.What is changing?
See release highlights.
Is there new documentation needed for these changes?
No, internal changes only.
What is the motivation for this change?
Release Highlight
Add
SUBTYPE_SENSITIVE
onBinary
classWhen a BSON.Binary object is of 'sensitive' subtype, the object's subtype will equal
0x08
.Double check the following
npm run check:lint
scripttype(NODE-xxxx)[!]: description
feat(NODE-1234)!: rewriting everything in coffeescript