fix(mongos): bubble up close events after the first one #1713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbroadst
approved these changes
May 31, 2018
|
thanks val! |
|
Thanks Matt! Any ETA on 3.0.9? |
|
Just need to finish review on some current changes, and we can publish it by tomorrow at latest |
mbroadst
pushed a commit
that referenced
this pull request
May 31, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Automattic/mongoose#6249
In addition to the changes in #1685, I put together a test that fails when
mongos.jsis unchanged. Should make it clear why this change is necessary.As far as mongoose is concerned, the 'close' event is what matters, so I'd be open to leaving the 'timeout' and 'error' events as
once()if that helps address any concerns.