fix(db_ops): call collection.find() with correct parameters #1795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes NODE-1596
rweinberger
approved these changes
Jul 30, 2018
mbroadst
suggested changes
Jul 31, 2018
lib/operations/db_ops.js
Outdated
| } | ||
| ); | ||
| }); | ||
| finalOptions.projection = { dbName: 1 }; |
There was a problem hiding this comment.
finalOptions is subsequently used for the below updateOne call, so you have inadvertently added a projection to that command.
daprahamian
reviewed
Jul 31, 2018
lib/operations/db_ops.js
Outdated
| } | ||
| ); | ||
| }); | ||
| let findOptions = finalOptions; |
There was a problem hiding this comment.
This can be const, since we are not changing the reference.
mbroadst
approved these changes
Aug 8, 2018
kiku-jw
pushed a commit
to kiku-jw/node-mongodb-native
that referenced
this pull request
Feb 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes NODE-1596