Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use require instead of readFileSync for driver.version (#2937) #2652

Merged
merged 3 commits into from
Dec 4, 2020

Conversation

aherlihy
Copy link
Contributor

@aherlihy aherlihy commented Dec 2, 2020

This is the solution mongosh is currently using in my fork of the driver. I don't know if you want to use this directly or some other solution. For more details see NODE-2937

@kmahar
Copy link
Contributor

kmahar commented Dec 2, 2020

(@aherlihy I just added people for review myself so should be all good)

Copy link
Contributor

@emadum emadum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are a few lint errors from the now-unused vars:

warning  'readFileSync' is defined but never used  @typescript-eslint/no-unused-vars
warning  'resolve' is defined but never used       @typescript-eslint/no-unused-vars

@aherlihy
Copy link
Contributor Author

aherlihy commented Dec 4, 2020

Right! Sorry I missed that, should be done @emadum

@emadum emadum merged commit e7a42bb into mongodb:master Dec 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants