feat: introduce BufferPool to replace BufferList #2669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbroadst
force-pushed
the
NODE-2930/replace-bl-dependency
branch
from
ee28cf1
to
1f3ab36
Compare
BufferList really helped simplify a lot of code in our message stream processing, but ultimately is more powerful than we need it to be. Additionally, depending on this package makes maintenance of the driver more difficult over time. This introduces a new type called BufferList which is tailored to our particular use case. NODE-2930
mbroadst
force-pushed
the
NODE-2930/replace-bl-dependency
branch
from
1f3ab36
to
31d2b36
Compare
nbbeeken
requested changes
Dec 8, 2020
emadum
suggested changes
Dec 9, 2020
| @@ -991,10 +991,10 @@ export interface InterruptableAsyncInterval { | |||
| * | |||
| * @param fn - An async function to run on an interval, must accept a `callback` as its only parameter | |||
| */ | |||
| export function makeInterruptableAsyncInterval( | |||
| export function makeInterruptibleAsyncInterval( | |||
There was a problem hiding this comment.
This import needs to be updated in test/unit/utils.test.js to fix CI
mbroadst
force-pushed
the
NODE-2930/replace-bl-dependency
branch
from
6c66b4a
to
51fe597
Compare
nbbeeken
approved these changes
Dec 9, 2020
emadum
approved these changes
Dec 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BufferList really helped simplify a lot of code in our message stream processing, but ultimately is more powerful than we need it to be. Additionally, depending on this package makes maintenance of the driver more difficult over time. This introduces a new type called BufferList which is tailored to our particular use case.
NODE-2930