feat!: Integrate MongoOptions parser into driver #2680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbbeeken
force-pushed
the
NODE-2704/integrate-mongoOptions
branch
7 times, most recently
from
09174ae
to
74232bc
Compare
nbbeeken
force-pushed
the
NODE-2704/integrate-mongoOptions
branch
from
74232bc
to
687baea
Compare
nbbeeken
force-pushed
the
NODE-2704/integrate-mongoOptions
branch
from
687baea
to
13278cf
Compare
MongoOptions introduce a well typed HostAddress type that tracks the correct shape of a host's address depending on its type. The MongoClientOptions type inherit from node's TLS and Socket options and use our allow list of options to maintain a connection between the types and programmatic processing of options. The hierarchy of options from MongoClient > Topology > Server > ConnectionPool > Connection have been corrected and clarified for responsibilities. NODE-2704
nbbeeken
force-pushed
the
NODE-2704/integrate-mongoOptions
branch
from
13278cf
to
8f265c9
Compare
emadum
reviewed
Jan 6, 2021
src/logger.ts
Outdated
| @@ -48,7 +48,7 @@ export class Logger { | |||
| this.className = className; | |||
|
|
|||
| // Current logger | |||
| if (options.logger) { | |||
| if (!(options.logger instanceof Logger) && typeof options.logger === 'function') { | |||
| currentLogger = options.logger; | |||
| } else if (currentLogger == null) { | |||
There was a problem hiding this comment.
nit: now that currentLogger defaults to console.warn above, I don't think this branch will ever trigger.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MongoOptions introduce a well typed HostAddress type that tracks
the correct shape of a host's address depending on its type.
The MongoClientOptions type inherit from node's TLS and Socket options
and use our allow list of options to maintain a connection between the
types and programmatic processing of options. The hierarchy of options
from MongoClient > Topology > Server > ConnectionPool > Connection have
been corrected and clarified for responsibilities.
NODE-2704