fix: revert BSON Map export removal #2704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emadum
approved these changes
Jan 15, 2021
|
@nbbeeken Fwiw, we already worked around this in mongodb-js/mongosh@39e6dfb – you can keep these dropped if that’s what you prefer for 4.0. |
|
Thanks for the heads up! I think we want to keep it until it would be removed from the BSON lib in it's major version, despite it not being the most useful. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Good news! Our mongosh early warning system works!
Looks like I dropped the Map export from BSON by mistake, here's the fix.