-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor!: remove deprecated items #2740
Conversation
3b45cef
to
b7cb028
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, very nice to see all that legacy code removed! 👍
* so using string interpolation can cause multiple emits | ||
* @internal | ||
*/ | ||
export function emitWarningOnce(message: string): void { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, this was exactly what I was thinking we should do 🥇
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@addaleax These are the deprecations in 3.6 that are slated for removal in 4.0, there are failures with the mongosh tests. If you (or a colleague) get the chance, could you take a look and give us some insight into what is expected/unexpected here. I'll spare pinging you twice but same goes for: #2741 |
It's failing during typescript compilation in both cases (I know the test logs can be a bit messy -- it's generally helpful to grep around for the first
and for #2741
The latter is probably not hard to address, you can merge it and we'll probably really just have to add For the And thanks for the ping! :) |
Removals are noted in JIRA ticket. NODE-2317
d5d045e
to
bccf01a
Compare
Thanks for going through the logs! Sounds like we're good to go, of course let us know if we can advise/help out with the
and that's what makes it do the same thing as findOneAndUpdate, findOneAndDelete, findOneAndReplace. |
Removals are noted in JIRA ticket. NODE-2317
Removals are noted in JIRA ticket.
NODE-2317
Some of the deprecations are not to be removed (e.g, Collection#insert) but a warning should still be emitted I wrote a small wrapper around process.emitWarning that we should also port to 3.6. This allows us to drop the deprecate calls that come after the class definition (e.g,
deprecate(Collection.prototype.insert, ...)
) and move aemitWarningOnce
call into the method itself.