Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NODE-3109): prevent servername from being IP [PORT 4.0] #2771

Merged
merged 1 commit into from
Apr 8, 2021
Merged

fix(NODE-3109): prevent servername from being IP [PORT 4.0] #2771

merged 1 commit into from
Apr 8, 2021

Conversation

nbbeeken
Copy link
Contributor

PORT to 4.0

servername should only ever be a hostname. Add a condition
to check if the host is an IP and skip auto setting the servername.

@nbbeeken nbbeeken requested review from durran and emadum March 29, 2021 21:39
@nbbeeken nbbeeken changed the title NODE-3109/4.0/no-ip-in-sni fix(NODE-3109): prevent servername from being IP [PORT 4.0] Mar 29, 2021
durran
durran approved these changes Apr 7, 2021
View reviewed changes
Copy link
Member

@durran durran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nbbeeken nbbeeken merged commit 27089be into 4.0 Apr 8, 2021
@nbbeeken nbbeeken deleted the NODE-3109/4.0/no-ip-in-sni branch April 8, 2021 14:21
ljhaywar pushed a commit that referenced this pull request Nov 9, 2021
@nbbeeken @ljhaywar
fix(NODE-3109): prevent servername from being an IP (#2771)
22c2a8d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emadum emadum emadum approved these changes

@durran durran durran approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nbbeeken @durran @emadum