Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(NODE-2995): Add shared metadata MongoClient [PORT 4.0] #2772

Merged
merged 1 commit into from
Apr 8, 2021

Conversation

nbbeeken
Copy link
Contributor

Automatic client side encryption needs to perform metadata look ups
like listCollections. In situations where the connection pool size
is constrained or in full use it can be impossible for an operation
to proceed. Adding a separate client in these situations permits the
metadata look ups to proceed unblocking operations.

@nbbeeken nbbeeken force-pushed the NODE-2995/4.0/CSFLE-meta-client branch 2 times, most recently from 722aa0c to 4ca268b Compare April 2, 2021 16:30
@nbbeeken nbbeeken marked this pull request as ready for review April 2, 2021 16:31
@nbbeeken nbbeeken requested review from durran and emadum April 2, 2021 16:31
Automatic client side encryption needs to perform metadata look ups
like listCollections. In situations where the connection pool size
is constrained or in full use it can be impossible for an operation
to proceed. Adding a separate client in these situations permits the
metadata look ups to proceed unblocking operations.
@nbbeeken nbbeeken force-pushed the NODE-2995/4.0/CSFLE-meta-client branch from 4ca268b to 1e4cf32 Compare April 2, 2021 16:36
Copy link
Member

@durran durran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nbbeeken nbbeeken merged commit 9073d54 into 4.0 Apr 8, 2021
@nbbeeken nbbeeken deleted the NODE-2995/4.0/CSFLE-meta-client branch April 8, 2021 14:23
ljhaywar pushed a commit that referenced this pull request Nov 9, 2021
Automatic client side encryption needs to perform metadata look ups
like listCollections. In situations where the connection pool size
is constrained or in full use it can be impossible for an operation
to proceed. Adding a separate client in these situations permits the
metadata look ups to proceed unblocking operations.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants