Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor!: remove deprecated bulk ops #2794

Merged
merged 3 commits into from
May 5, 2021
Merged

refactor!: remove deprecated bulk ops #2794

merged 3 commits into from
May 5, 2021

Conversation

emadum
Copy link
Contributor

@emadum emadum commented Apr 29, 2021

@emadum emadum requested review from dariakp and durran April 30, 2021 15:59
dariakp
dariakp requested changes Apr 30, 2021
View reviewed changes
Copy link
Contributor

@dariakp dariakp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the removed operations should also be removed from the doc comments listing legal operation types in the collection.ts for bulkWrite

@emadum emadum marked this pull request as ready for review May 3, 2021 19:45
@emadum emadum requested a review from dariakp May 3, 2021 19:49
dariakp
dariakp approved these changes May 3, 2021
View reviewed changes
Copy link
Contributor

@dariakp dariakp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

durran
durran approved these changes May 4, 2021
View reviewed changes
Copy link
Member

@durran durran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@emadum emadum merged commit c3a1839 into 4.0 May 5, 2021
@emadum emadum deleted the NODE-2978/4.0/remove-deprecated-bulk-ops branch May 5, 2021 14:11
ljhaywar pushed a commit that referenced this pull request Nov 9, 2021
@emadum @ljhaywar
refactor(NODE-2978)!: remove deprecated bulk ops (#2794)
ef5627a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@durran durran durran approved these changes

@dariakp dariakp dariakp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@emadum @durran @dariakp