fix(NODE-3311): Fix "session" typescript typing for "insertOne" options. #2816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j
force-pushed
the
session-typings
branch
2 times, most recently
from
8491d43
to
4e0a48f
Compare
j
changed the title
|
Hi, thanks for catching it! This does seem like the correct fix, I'll add it to our review queue. :) |
dariakp
requested review from
a team,
durran,
emadum and
nbbeeken
and removed request for
a team
dariakp
approved these changes
May 26, 2021
|
@dariakp @nbbeeken It was a lot of work! :P. I can bring up any issues I come across. With this PR, all my tests for type-mongodb pass. Great work with the new driver. |
emadum
suggested changes
May 26, 2021
There was a problem hiding this comment.
Thanks for the fix! One small request - can you remove the now-unused imports? Our lint check is complaining:
/data/mci/2e60a5e8f169e69a6e99236d7cd23982/src/src/operations/insert.ts
8:25 warning 'BSONSerializeOptions' is defined but never used @typescript-eslint/no-unused-vars
10:24 warning 'WriteConcernOptions' is defined but never used @typescript-eslint/no-unused-vars
✖ 2 problems (0 errors, 2 warnings)
Should be updated. Somehow lint & test was passing locally. |
emadum
approved these changes
May 26, 2021
ljhaywar
pushed a commit
that referenced
this pull request
Nov 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NODE-3311
insertOneis missing common options + session typings.