feat(NODE-2751): add arrayFilters builder to bulk FindOperators #2820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emadum
requested review from
a team,
durran,
nbbeeken and
dariakp
and removed request for
a team
durran
approved these changes
May 26, 2021
dariakp
changed the title
dariakp
reviewed
May 26, 2021
test/functional/bulk.test.js
Outdated
| bulk.execute(err => { | ||
| expect(err).to.not.exist; | ||
| expect(events).to.be.an('array').with.length(1); | ||
| expect(events[0]).property('commandName').to.equal('update'); |
There was a problem hiding this comment.
just a note: the property assertions can take the property name and value to compare directly, so this line is equivalent to expect(events[0]).to.have.property('commandName', 'update'); and if you go a step further and use the nested keyword, you could say expect(events).to.have.nested.property('0.commandName', 'update')
these are personal preferences, I just wanted to make you aware of the options in case any of them appeal to you
also be careful with the length assertion, since it can't be reliably chained in all cases (e.g., you can't chain it off a), so chai's own docs recommend to use lengthOf as a general rule, since that does work exactly as expected in all cases
nbbeeken
approved these changes
May 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NODE-2751