Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(NODE-3331): offer downleveled types for legacy typescript versions #2859

Merged
merged 2 commits into from
Jun 30, 2021

Conversation

nbbeeken
Copy link
Contributor

Downlevel-dts is now run when ever defintions are generated and our package points typescript versions equal to 4.0.2 and older to these defintions. They target the lowest version downlevel-dts supports which is 3.4. I added a check to our CI to make sure that 4.0.2 will use and remain compatible with these types.

Copy link
Contributor

@dariakp dariakp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dariakp dariakp added the Team Review Needs review from team label Jun 25, 2021
@dariakp dariakp requested review from durran and emadum June 25, 2021 19:54
Copy link
Contributor

@emadum emadum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just confirming about xtrace being on, otherwise LGTM!


export PROJECT_DIRECTORY="$(pwd)"
NODE_ARTIFACTS_PATH="${PROJECT_DIRECTORY}/node-artifacts"
export NVM_DIR="${NODE_ARTIFACTS_PATH}/nvm"
[ -s "$NVM_DIR/nvm.sh" ] && \. "$NVM_DIR/nvm.sh"

set -o xtrace
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this meant to stay here or is it left over from development? I find it generally clutters up logs having this on (and it can leak sensitive data).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just testing, now that I have the useful "echo"s we dont need this

@nbbeeken nbbeeken requested a review from emadum June 28, 2021 14:07
Copy link
Contributor

@emadum emadum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@emadum emadum merged commit 27cf1d2 into 4.0 Jun 30, 2021
@emadum emadum deleted the NODE-3331/downlevel-dts branch June 30, 2021 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team Review Needs review from team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants