fix(NODE-3574): reintroduce ObjectID export #2965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emadum
suggested changes
Sep 1, 2021
test/types/mongodb.test-d.ts
Outdated
| @@ -15,6 +16,8 @@ expectDeprecated(Collection.prototype.count); | |||
| expectDeprecated(AggregationCursor.prototype.geoNear); | |||
| expectDeprecated(Topology.prototype.unref); | |||
| expectDeprecated(Db.prototype.unref); | |||
| // expectDeprecated(ObjectID); // not sure why tsd can't assert the deprecation | |||
There was a problem hiding this comment.
I think this is because it's root level. I tried this out and it worked:
import * as AllExports from '../../src';
expectDeprecated(AllExports.ObjectID);
expectNotDeprecated(AllExports.ObjectId);
There was a problem hiding this comment.
Perfect, that works!
emadum
approved these changes
Sep 2, 2021
dariakp
reviewed
Sep 7, 2021
test/unit/bson_import.test.js
Outdated
| it('should include ObjectID', () => | ||
| expect(mongodb).to.have.property('ObjectID').that.is.a('function')); | ||
| it('should have ObjectID and ObjectId equal each other', () => | ||
| expect(mongodb.ObjectId).to.deep.equal(mongodb.ObjectID)); |
There was a problem hiding this comment.
Should this be just regular equal since we're actually expecting reference equality?
Suggested change
| expect(mongodb.ObjectId).to.deep.equal(mongodb.ObjectID)); | |
| expect(mongodb.ObjectId).to.equal(mongodb.ObjectID)); |
There was a problem hiding this comment.
Also, I don't think there should be any package lock changes for this PR
There was a problem hiding this comment.
Lock file changes fixed, and no longer checking deep equality 🚀
nbbeeken
force-pushed
the
NODE-3574/ObjectID
branch
from
4be2865
to
8c2792c
Compare
dariakp
approved these changes
Sep 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reintroduced the capitalized ObjectID export along with a deprecation tag.