Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(NODE-3878): use legacy count operation on collection.count #3126

Merged
merged 2 commits into from
Feb 7, 2022

Conversation

baileympearson
Copy link
Contributor

@baileympearson baileympearson commented Feb 3, 2022

Description

What is changing?

This PR updates Collection.count to use the legacy count operation. It also unskips tests that were failing when Collection.count was modified to use the new count operation.

Is there new documentation needed for these changes?

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: <type>(NODE-xxxx)<!>: <description>
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@baileympearson baileympearson force-pushed the NODE-3878-Collection-count-use-legacy-op branch from 6fd7a74 to 03c34a0 Compare February 4, 2022 19:22
Copy link
Contributor

@nbbeeken nbbeeken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

cc: @addaleax Just want to this change on your radar, it's an (overdue) revert. The deprecated count method should've continued to use the deprecated count operation, there is no visible user facing changes, only performance and accuracy depending on deployment. It may be worth surfacing the change in shell change notes, but not essential

@nbbeeken nbbeeken changed the title fix(NODE-3878): Use legacy count operation fix(NODE-3878): use legacy count operation on collection.count Feb 7, 2022
@nbbeeken nbbeeken merged commit 12c6835 into main Feb 7, 2022
@nbbeeken nbbeeken deleted the NODE-3878-Collection-count-use-legacy-op branch February 7, 2022 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants