Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NODE-3948): Add error code to MongoSystemError #3149

Merged
merged 6 commits into from
Feb 22, 2022
Merged

fix(NODE-3948): Add error code to MongoSystemError #3149

merged 6 commits into from
Feb 22, 2022

Conversation

baileympearson
Copy link
Contributor

Description

What is changing?

This PR adds an error code property to the MongoSystemError class.

This PR also converts the error tests to Typescript.

Is there new documentation needed for these changes?

No.

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: <type>(NODE-xxxx)<!>: <description>
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@nbbeeken nbbeeken changed the title fix(NODE-3948 ): Add error code to MongoSystemError fix(NODE-3948): Add error code to MongoSystemError Feb 22, 2022
@dariakp dariakp self-assigned this Feb 22, 2022
@dariakp dariakp added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Feb 22, 2022
dariakp
dariakp requested changes Feb 22, 2022
View reviewed changes
Copy link
Contributor

@dariakp dariakp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a couple of things

test/unit/error.test.ts Outdated Show resolved Hide resolved
test/unit/error.test.ts Outdated Show resolved Hide resolved
dariakp
dariakp requested changes Feb 22, 2022
View reviewed changes
Copy link
Contributor

@dariakp dariakp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a couple of nits, otherwise lgtm

test/unit/error.test.ts Outdated Show resolved Hide resolved
test/unit/error.test.ts Outdated Show resolved Hide resolved
test/unit/error.test.ts Outdated Show resolved Hide resolved
@dariakp dariakp added Team Review Needs review from team and removed Primary Review In Review with primary reviewer, not yet ready for team's eyes labels Feb 22, 2022
nbbeeken
nbbeeken requested changes Feb 22, 2022
View reviewed changes
test/unit/error.test.ts Outdated Show resolved Hide resolved
test/unit/error.test.ts Show resolved Hide resolved
@baileympearson
Address PR comments
1eda3f1 
- use ts-expect-error instead of `as any` when purposely using an incorrect type
- clean up new `it` block descriptions
dariakp
dariakp previously approved these changes Feb 22, 2022
View reviewed changes
Copy link
Contributor

@dariakp dariakp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

nbbeeken
nbbeeken requested changes Feb 22, 2022
View reviewed changes
test/unit/error.test.ts Outdated Show resolved Hide resolved
@dariakp dariakp merged commit 446da95 into main Feb 22, 2022
@dariakp dariakp deleted the NODE-3948-add-code-property-to-mongo-system-error branch February 22, 2022 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dariakp dariakp dariakp approved these changes

@nbbeeken nbbeeken nbbeeken approved these changes

Assignees

@dariakp dariakp

Labels
Team Review Needs review from team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@baileympearson @nbbeeken @dariakp