fix(NODE-3521): update session support checks #3151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dariakp
added
the
Primary Review
durran
changed the title
nbbeeken
reviewed
Feb 28, 2022
nbbeeken
reviewed
Feb 28, 2022
nbbeeken
previously approved these changes
Mar 1, 2022
nbbeeken
added
Team Review
dariakp
requested changes
Mar 1, 2022
baileympearson
requested changes
Mar 2, 2022
dariakp
previously approved these changes
Mar 2, 2022
Co-authored-by: Bailey Pearson <[email protected]>
Co-authored-by: Bailey Pearson <[email protected]>
Co-authored-by: Bailey Pearson <[email protected]>
dariakp
previously approved these changes
Mar 2, 2022
baileympearson
approved these changes
Mar 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With the increase of the minimum wire version, server versions below 3.6 are no longer supported and thus the need to check if a topology supports sessions is no longer needed. This check also caused session mismatch errors in rare cases when a topology went unknown before a cursor's initial
findcommand executed and came back before the subsequentgetMorecommand was executed.What is changing?
Removes all
hasSessionSupportchecks and tests that are no longer relevant.Is there new documentation needed for these changes?
No
What is the motivation for this change?
NODE-3521 / NODE-4009
Double check the following
npm run check:lintscript<type>(NODE-xxxx)<!>: <description>