Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(NODE-4136): revise FLE shared library typings for spec changes #3206

Merged
merged 3 commits into from
Apr 25, 2022

Conversation

addaleax
Copy link
Contributor

Description

Typings changes for mongodb/libmongocrypt#306

What is changing?

Is there new documentation needed for these changes?

What is the motivation for this change?

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: <type>(NODE-xxxx)<!>: <description>
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

src/deps.ts Show resolved Hide resolved
src/deps.ts Show resolved Hide resolved
src/deps.ts Outdated Show resolved Hide resolved
src/deps.ts Show resolved Hide resolved
@addaleax addaleax requested a review from nbbeeken April 20, 2022 15:00
@nbbeeken nbbeeken added the Team Review Needs review from team label Apr 20, 2022
nbbeeken
nbbeeken previously approved these changes Apr 20, 2022
Copy link
Contributor

@nbbeeken nbbeeken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ty!

@nbbeeken nbbeeken merged commit 6e2e27f into mongodb:main Apr 25, 2022
@addaleax addaleax deleted the node-4136-dev branch April 25, 2022 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team Review Needs review from team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants