fix(NODE-3833): return early on end if gridfs upload stream is already ended #3223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbbeeken
added
the
Primary Review
nbbeeken
added
Team Review
baileympearson
approved these changes
Apr 29, 2022
durran
approved these changes
Apr 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
NODE-3833
What is changing?
Fixed the
endoverride on upload gridfs stream to return early on repeat calls.Is there new documentation needed for these changes?
What is the motivation for this change?
We don't want to write duplicate chunks to the steam after it has already ended.
Among other things, this fix ensures we are not affected by the following
pipelinebug:nodejs/node#42866
Double check the following
npm run check:lintscript<type>(NODE-xxxx)<!>: <description>