Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(NODE-4208): add aws http request timeout handler #3225

Merged
merged 4 commits into from
May 2, 2022

Conversation

dariakp
Copy link
Contributor

@dariakp dariakp commented Apr 29, 2022

Description

NODE-4208

What is changing?

  • Adding a new subclass of MongoRunTimeError: MongoAWSError (inspired by the analogous error class for Kerberos)
  • Adding a handler for the http request timeout error for AWS requests
  • Adding a new environment variable to the EC2 test suite so that the new integration test can run only in the EC2 environment (since the other AWS test suites have credentials already available without the http call)
Is there new documentation needed for these changes?

No

What is the motivation for this change?

Fixes a bug where the default specified timeout of 10000ms for aws http requests was not being respected.

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: <type>(NODE-xxxx)<!>: <description>
  • Changes are covered by tests
  • [N/A] New TODOs have a related JIRA ticket

@dariakp dariakp added the Team Review Needs review from team label Apr 29, 2022
@durran durran merged commit 829d7be into main May 2, 2022
@durran durran deleted the NODE-4208/aws-http-timeout-handler branch May 2, 2022 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team Review Needs review from team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants