-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(NODE-4103): respect BSON options when creating change streams #3247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baileympearson
approved these changes
May 17, 2022
baileympearson
requested changes
May 17, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't mean to approve, I hit the wrong button
…o remove collection after every test
baileympearson
approved these changes
May 19, 2022
baileympearson
changed the title
fix(NODE-4103): collection.watch doesn't respect promoteLongs option
fix(NODE-4103): respect BSON options when creating change streams
May 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
NODE-4103
What is changing?
The use of the filterOptions function was removed from the ChangeStreamCursor constructor.
Is there new documentation needed for these changes?
What is the motivation for this change?
The filterOptions function being used to filter the options passed into into the changeStreamCursor constructor, was filtering out the usage of any of the BSON options being passed in. So the function was removed to allow BSON options to be passed through successfully and any invalid options would be handled by the existing filtering already present.
When calling collection.watch with the BSON option
{ promoteLongs: false } and inserting a document { long: Long.fromNumber(0) } to a collection, the document emitted from the change stream should contain a long with the value 0. However, before the changes made, the filter options were preventing promoteLongs from being passed successfully, so the 0 inserted into the document would be of type number instead of an instance of Long as we specified in our options.
Double check the following
npm run check:lint
script<type>(NODE-xxxx)<!>: <description>