-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(NODE-4267): support nested fields in type completion for UpdateFilter #3259
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
The type-checking is not as strict as it could be
6544d6d
to
059dc3d
Compare
059dc3d
to
ca85520
Compare
Co-authored-by: Julien Chaumond <[email protected]>
Hey @julien-c! Thanks for this contribution. The Node team is interested in adding this feature to the driver but we don't have the bandwidth at the moment to evaluate the changes and get it merged. We plan on scheduling this work - you can track the status in the Jira ticket you filed (https://jira.mongodb.org/browse/NODE-4267). |
@julien-c Looks like this branch is behind main, and has some failing tests in CI that should pass with updates. Do you want to update the branch with changes in main? I also don't mind doing it, if you don't mind me pushing to your branch. |
@baileympearson I updated the branch - feel free to update it too if needed :) |
Thanks - and sorry for pinging the wrong user about this PR! |
@coyotte508 Thanks for taking the time to help us with this and thank you for being patient with us! |
There's a regression when wanting to update nested objects directly: interface User {
subscription: {
paymentMethod: {
last4: string;
expiration: Date;
}
}
} I can update Edit: posted in the Jira issue |
Description
What is changing?
The
MatchKeysAndValues
type used byUpdateFilter
is changed, inspired by theFilter
type for querying.Is there new documentation needed for these changes?
No
What is the motivation for this change?
The
Filter
type for querying is very nice. But theUpdateFilter
type doesn't support type completion for nested fields.https://jira.mongodb.org/projects/NODE/issues/NODE-4267
Double check the following
npm run check:lint
script<type>(NODE-xxxx)<!>: <description>