fix(NODE-4413): set maxTimeMS on getMores when maxAwaitTimeMS is specified #3319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
nbbeeken
force-pushed
the
NODE-4173/test-maxAwaitTimeMS
branch
2 times, most recently
from
aeabbd7
to
ef2ea17
Compare
nbbeeken
force-pushed
the
NODE-4173/test-maxAwaitTimeMS
branch
2 times, most recently
from
74fdbb3
to
f8647fa
Compare
nbbeeken
force-pushed
the
NODE-4173/test-maxAwaitTimeMS
branch
from
02c678a
to
7a23092
Compare
nbbeeken
changed the title
baileympearson
changed the title
baileympearson
changed the title
baileympearson
requested changes
Aug 2, 2022
Comment on lines
+648
to
+649
| // eslint-disable-next-line @typescript-eslint/no-non-null-assertion | ||
| const getMoreOperation = new GetMoreOperation(this[kNamespace], this[kId]!, this[kServer]!, { |
There was a problem hiding this comment.
Do we have tests that test for errors being thrown when execute is called on a zero-ed cursor or if the server is undefined? If not, can we add them to demonstrate this behavior still exists?
baileympearson
added
the
Primary Review
nbbeeken
requested review from
baileympearson and
dariakp
and removed request for
baileympearson
nbbeeken
force-pushed
the
NODE-4173/test-maxAwaitTimeMS
branch
from
ac2b000
to
7b956a2
Compare
dariakp
requested changes
Aug 4, 2022
nbbeeken
force-pushed
the
NODE-4173/test-maxAwaitTimeMS
branch
from
0e2117d
to
83c1b56
Compare
dariakp
removed
the
Primary Review
dariakp
reviewed
Aug 9, 2022
| .expectEvents({ | ||
| client: 'client0', | ||
| events: [ | ||
| { commandStartedEvent: { commandName: 'aggregate' } }, |
There was a problem hiding this comment.
why do we assert absence of the prop on the getMore in the 2nd case, but not on the initial aggregate here? what's the actual expected behavior from these options in the two cases?
There was a problem hiding this comment.
Added an (not) existence check, and clarified the titles
baileympearson
approved these changes
Aug 10, 2022
dariakp
approved these changes
Aug 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is changing?
What is the motivation for this change?
Fix maxAwaitTimeMS not being respected by change stream getMores (all getMores were impacted actually)
Double check the following
npm run check:lintscript<type>(NODE-xxxx)<!>: <description>