Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NODE-4273): pass 'comment' option through to distinct command #3339

Merged
merged 8 commits into from
Aug 3, 2022
Merged

fix(NODE-4273): pass 'comment' option through to distinct command #3339

merged 8 commits into from
Aug 3, 2022

Conversation

baileympearson
Copy link
Contributor

@baileympearson baileympearson commented Jul 28, 2022 •
edited
Loading

Description

What is changing?

The comment option is now attached to the distinct command.

Is there new documentation needed for these changes?

No.

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: <type>(NODE-xxxx)<!>: <description>
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@baileympearson baileympearson force-pushed the NODE-4273 branch 2 times, most recently from ed2cfa3 to 98345f3 Compare August 1, 2022 18:49
nbbeeken
nbbeeken previously approved these changes Aug 1, 2022
View reviewed changes
@nbbeeken
Copy link
Contributor

nbbeeken commented Aug 1, 2022

Changes LGTM, CI should be fixed with a rebase we think.

@baileympearson baileympearson marked this pull request as ready for review August 2, 2022 19:09
@baileympearson baileympearson added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Aug 2, 2022
nbbeeken
nbbeeken previously approved these changes Aug 2, 2022
View reviewed changes
@nbbeeken nbbeeken added Team Review Needs review from team and removed Primary Review In Review with primary reviewer, not yet ready for team's eyes labels Aug 2, 2022
@nbbeeken nbbeeken merged commit 753ecfe into main Aug 3, 2022
@nbbeeken nbbeeken deleted the NODE-4273 branch August 3, 2022 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dariakp dariakp dariakp approved these changes

@nbbeeken nbbeeken nbbeeken approved these changes

Assignees
No one assigned
Labels
Team Review Needs review from team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@baileympearson @nbbeeken @dariakp