Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NODE-3144): pool clear event ordering and retryability tests #3407

Merged
merged 15 commits into from
Sep 15, 2022
Merged

fix(NODE-3144): pool clear event ordering and retryability tests #3407

merged 15 commits into from
Sep 15, 2022

Conversation

dariakp
Copy link
Contributor

@dariakp dariakp commented Sep 12, 2022 •
edited
Loading

Description

NODE-3144

What is changing?

  • Fixed the ordering of PoolCleared event to happen before the corresponding CheckOutFailed events from waitqueue eviction
  • Implemented retryable reads and writes prose tests
    • As part of this, I reorganized the existing retryable write prose test so that it would uniformly reset the failPoint with the new added test, but otherwise left it alone
Is there new documentation needed for these changes?

No

What is the motivation for this change?

Spec compliance

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: <type>(NODE-xxxx)<!>: <description>
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@dariakp dariakp marked this pull request as ready for review September 13, 2022 18:13
@durran durran self-assigned this Sep 13, 2022
@durran durran added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Sep 13, 2022
durran
durran previously approved these changes Sep 14, 2022
View reviewed changes
@durran durran added Team Review Needs review from team and removed Primary Review In Review with primary reviewer, not yet ready for team's eyes labels Sep 14, 2022
@durran durran removed their assignment Sep 14, 2022
@nbbeeken nbbeeken self-requested a review September 14, 2022 20:53
nbbeeken
nbbeeken previously approved these changes Sep 14, 2022
View reviewed changes
@dariakp dariakp dismissed stale reviews from nbbeeken and durran via 746adfa September 14, 2022 21:25
@durran durran merged commit bdc0d67 into main Sep 15, 2022
@durran durran deleted the NODE-3144/pool-cleared-retryable-prose-tests branch September 15, 2022 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@durran durran durran approved these changes

@baileympearson baileympearson baileympearson left review comments

@nbbeeken nbbeeken nbbeeken left review comments

Assignees
No one assigned
Labels
Team Review Needs review from team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dariakp @durran @nbbeeken @baileympearson