-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(NODE-4810): define the new Logger #3475
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there
Co-authored-by: Daria Pardue <[email protected]>
Co-authored-by: Daria Pardue <[email protected]>
Co-authored-by: Daria Pardue <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please address the comments in the feature_flags file; otherwise, just a few clean up comments on the mongo_logger.test.ts around the severity helpers and defaults; the testing is exhaustive, and there are improvements that could be made there to condense them by analyzing which cases are redundant (i.e., we want to test each component and each severity level at least once, but testing every component with every severity is overkill; likewise, when testing defaults, just one test case where nothing is set and assertions for the default on each expected thing is enough). If we want to just get these changes in, I am not going to insist on reworking the test cases right now (because they do cover everything), but then we'll need to revisit this and rewrite them in a more maintainable way when we go to implement client option handling for these settings.
I can't find any documentation about this new Logger in the API docs or the v5.0.0 changes doc. Where can we read more about this? |
Hey @avaly - the new logger is still in development, is currently unused inside the driver and is not intended to be consumed yet. Once development is finished, we'll include information and links to relevant documentation in the release notes for whichever release it is a part of. |
Description
What is changing?
Defines the new Logger class as described by NODE-3974. This PR handles the options parsing and instantiation of the logger.
Is there new documentation needed for these changes?
What is the motivation for this change?
Double check the following
npm run check:lint
script<type>(NODE-xxxx)<!>: <description>