-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(NODE-3470): retry selects another mongos #3963
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
durran
force-pushed
the
NODE-3470
branch
10 times, most recently
from
January 16, 2024 14:42
348cc5c
to
d8fb63b
Compare
alenakhineika
added
the
Primary Review
In Review with primary reviewer, not yet ready for team's eyes
label
Jan 16, 2024
alenakhineika
approved these changes
Jan 17, 2024
alenakhineika
added
Team Review
Needs review from team
and removed
Primary Review
In Review with primary reviewer, not yet ready for team's eyes
labels
Jan 17, 2024
baileympearson
approved these changes
Jan 18, 2024
This was referenced Jun 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When retrying reads and writes on a sharded cluster, will attempt the retry on a different mongos if multiple mongoses are present.
What is changing?
executeOperation
now keeps track of the previously selected server.Is there new documentation needed for these changes?
None
What is the motivation for this change?
NODE-3470
Release Highlight
When retrying reads or writes on a sharded cluster, the driver will attempt to select a different mongos for the retry if multiple are present.
Double check the following
npm run check:lint
scripttype(NODE-xxxx)[!]: description
feat(NODE-1234)!: rewriting everything in coffeescript