-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(NODE-3681): Typescript error in Collection.findOneAndModify UpdateFilter $currentDate #4047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
testing fix testing fix 2
aditi-khare-mongoDB
force-pushed
the
NODE-3681/current-date-type
branch
from
March 19, 2024 19:19
6009384
to
c9c1dd2
Compare
aditi-khare-mongoDB
force-pushed
the
NODE-3681/current-date-type
branch
from
March 20, 2024 15:38
1c62069
to
1fb2009
Compare
baileympearson
approved these changes
Mar 21, 2024
CI failures are unrelated. All TS-related tasks pass in CI. |
aditi-khare-mongoDB
added a commit
that referenced
this pull request
Apr 5, 2024
…eFilter $currentDate (#4047)
This was referenced Sep 6, 2024
This was referenced Sep 7, 2024
This was referenced Sep 24, 2024
This was referenced Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When a field with boolean value
true
, is passed into$currentDate
, it will no longer throw an TS error.What is changing?
Example:
Is there new documentation needed for these changes?
No.
What is the motivation for this change?
The motivation is that the Node Driver should not output unnecessary errors to users.
Release Highlight
Collection.findOneAndModify
'sUpdateFilter.$currentDate
no longer throws on collections with limited schemaExample:
Double check the following
npm run check:lint
scripttype(NODE-xxxx)[!]: description
feat(NODE-1234)!: rewriting everything in coffeescript