Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: introduce AbstractCursor and its concrete subclasses #2619

Merged
merged 14 commits into from
Nov 25, 2020
Merged

feat: introduce AbstractCursor and its concrete subclasses #2619

merged 14 commits into from
Nov 25, 2020

Commits on Nov 25, 2020

  1. feat: introduce AbstractCursor and its concrete subclasses 

    This change introduces a fundamental redesign of the cursor types
in the driver. The first change is to add a new `AbstractCursor`
type, which is only concerned with iterating a cursor (using
`getMore`) once it has been initialized. The `_initialize` method
must be implemented by subclasses. The concrete subclasses are
generally builders for `find` and `aggregate` commands, each
providing their own custom initialization method.

NODE-2809
    @mbroadst
    mbroadst committed Nov 25, 2020
    Configuration menu
    Copy the full SHA
    191c69b View commit details
    Browse the repository at this point in the history

  2. clamp readBufferedDocuments to [0, bufferedCount]

    @mbroadst
    mbroadst committed Nov 25, 2020
    Configuration menu
    Copy the full SHA
    5cf7748 View commit details
    Browse the repository at this point in the history

  3. Document => ResumeToken

    @mbroadst
    mbroadst committed Nov 25, 2020
    Configuration menu
    Copy the full SHA
    c589a34 View commit details
    Browse the repository at this point in the history

  4. remove comment about properties belonging

    @mbroadst
    mbroadst committed Nov 25, 2020
    Configuration menu
    Copy the full SHA
    c2bd343 View commit details
    Browse the repository at this point in the history

  5. add cursor initialization checks

    @mbroadst
    mbroadst committed Nov 25, 2020
    Configuration menu
    Copy the full SHA
    e0efd09 View commit details
    Browse the repository at this point in the history

  6. move lodash to dev deps

    @mbroadst
    mbroadst committed Nov 25, 2020
    Configuration menu
    Copy the full SHA
    f2d1e73 View commit details
    Browse the repository at this point in the history

  7. typo initialized

    @mbroadst
    mbroadst committed Nov 25, 2020
    Configuration menu
    Copy the full SHA
    037e759 View commit details
    Browse the repository at this point in the history

  8. default batchSize to 0 for legacy find path

    @mbroadst
    mbroadst committed Nov 25, 2020
    Configuration menu
    Copy the full SHA
    c99d32f View commit details
    Browse the repository at this point in the history

  9. support custom provided promise

    @mbroadst
    mbroadst committed Nov 25, 2020
    Configuration menu
    Copy the full SHA
    b0d105e View commit details
    Browse the repository at this point in the history

  10. remove unimplemented test

    @mbroadst
    mbroadst committed Nov 25, 2020
    Configuration menu
    Copy the full SHA
    fe56c1a View commit details
    Browse the repository at this point in the history

  11. make number optional for readBufferedDocuments

    @mbroadst
    mbroadst committed Nov 25, 2020
    Configuration menu
    Copy the full SHA
    5bb33b4 View commit details
    Browse the repository at this point in the history

  12. remove isClosed() method, depend on closed accessor

    @mbroadst
    mbroadst committed Nov 25, 2020
    Configuration menu
    Copy the full SHA
    207e774 View commit details
    Browse the repository at this point in the history

  13. handle explain for legacy servers

    @mbroadst
    mbroadst committed Nov 25, 2020
    Configuration menu
    Copy the full SHA
    a68a164 View commit details
    Browse the repository at this point in the history

  14. Update test/functional/abstract_cursor.test.js 

    Co-authored-by: Eric Adum <[email protected]>
    @mbroadst @emadum
    mbroadst and emadum committed Nov 25, 2020
    Configuration menu
    Copy the full SHA
    bcb37b0 View commit details
    Browse the repository at this point in the history