fix(NODE-3197): revert setImmediate in waitQueue #2802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A performance regression was identified in switching the connection pool to using setImmediate instead of process.nextTick for wait queue processing. This patch reverts that change.
nbbeeken
requested review from
a team,
durran,
emadum and
dariakp
and removed request for
a team
dariakp
approved these changes
May 11, 2021
wa-Nadoo
reviewed
May 11, 2021
src/cmap/connection_pool.ts
Outdated
| @@ -231,7 +231,7 @@ export class ConnectionPool extends EventEmitter { | |||
| } | |||
|
|
|||
| this[kWaitQueue].push(waitQueueMember); | |||
| setImmediate(() => processWaitQueue(this)); | |||
| process.nextTick(() => processWaitQueue(this)); | |||
There was a problem hiding this comment.
process.nextTick() forwards the second and subsequent arguments to the callback function. It permits to avoid creating an unnecessary closure and improves performance further. It's a very popular pattern across the Node.js core codebase (https://github.com/nodejs/node/search?p=1&q=process.nextTick+path%3Alib%2F).
Suggested change
| process.nextTick(() => processWaitQueue(this)); | |
| process.nextTick(processWaitQueue, this); |
There was a problem hiding this comment.
Thanks for taking the time to suggest this, I agree we can drop the closure
emadum
approved these changes
May 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A performance regression was identified in switching the connection pool to using setImmediate instead of process.nextTick for wait queue processing. This patch reverts that change.
NODE-3197