Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NODE-2035): exceptions thrown from awaited cursor forEach do not propagate #2835

Merged
merged 17 commits into from
Jun 17, 2021
Merged

fix(NODE-2035): exceptions thrown from awaited cursor forEach do not propagate #2835

merged 17 commits into from
Jun 17, 2021

Commits on Jun 17, 2021

  1. Started NODE-2035 solution

    @W-A-James
    W-A-James committed Jun 17, 2021
    Configuration menu
    Copy the full SHA
    c15f6ec View commit details
    Browse the repository at this point in the history

  2. Fix in progress

    @W-A-James
    W-A-James committed Jun 17, 2021
    Configuration menu
    Copy the full SHA
    f9911ea View commit details
    Browse the repository at this point in the history

  3. Implemented fix and tweaked test

    @W-A-James
    W-A-James committed Jun 17, 2021
    Configuration menu
    Copy the full SHA
    c54ee67 View commit details
    Browse the repository at this point in the history

  4. cleanup

    @W-A-James
    W-A-James committed Jun 17, 2021
    Configuration menu
    Copy the full SHA
    fbb19d5 View commit details
    Browse the repository at this point in the history

  5. Remove extraneous comment

    @W-A-James
    W-A-James committed Jun 17, 2021
    Configuration menu
    Copy the full SHA
    86e7fb7 View commit details
    Browse the repository at this point in the history

  6. style: renamed variable for readability

    @W-A-James
    W-A-James committed Jun 17, 2021
    Configuration menu
    Copy the full SHA
    01fb7b8 View commit details
    Browse the repository at this point in the history

  7. test: restructured test

    @W-A-James
    W-A-James committed Jun 17, 2021
    Configuration menu
    Copy the full SHA
    66d4c3c View commit details
    Browse the repository at this point in the history

  8. test: Made sure test will fail if no error occurs

    @W-A-James
    W-A-James committed Jun 17, 2021
    Configuration menu
    Copy the full SHA
    a2defc6 View commit details
    Browse the repository at this point in the history

  9. fix: Remove extraneous console.error statement

    @W-A-James
    W-A-James committed Jun 17, 2021
    Configuration menu
    Copy the full SHA
    01ebd5a View commit details
    Browse the repository at this point in the history

  10. fix: replaced console.error with appropriate assertion

    @W-A-James
    W-A-James committed Jun 17, 2021
    Configuration menu
    Copy the full SHA
    f1796a0 View commit details
    Browse the repository at this point in the history

  11. fix: Removed unnecessary if statements

    @W-A-James
    W-A-James committed Jun 17, 2021
    Configuration menu
    Copy the full SHA
    5a99075 View commit details
    Browse the repository at this point in the history

  12. test: Added describe block to allow for cleaner test code

    @W-A-James
    W-A-James committed Jun 17, 2021
    Configuration menu
    Copy the full SHA
    2143b8f View commit details
    Browse the repository at this point in the history

  13. fix: Await completion of promises in test cleanup

    @W-A-James
    W-A-James committed Jun 17, 2021
    Configuration menu
    Copy the full SHA
    1bf21da View commit details
    Browse the repository at this point in the history

  14. test: Utilize async/await to clean up test case

    @W-A-James
    W-A-James committed Jun 17, 2021
    Configuration menu
    Copy the full SHA
    b200cc0 View commit details
    Browse the repository at this point in the history

  15. fix: Make test fail if no error is caught

    @W-A-James
    W-A-James committed Jun 17, 2021
    Configuration menu
    Copy the full SHA
    f19b463 View commit details
    Browse the repository at this point in the history

  16. fix: remove unnecessary function wrapping from test

    @W-A-James
    W-A-James committed Jun 17, 2021
    Configuration menu
    Copy the full SHA
    340041a View commit details
    Browse the repository at this point in the history

  17. fix: removed console.log statement

    @W-A-James
    W-A-James committed Jun 17, 2021
    Configuration menu
    Copy the full SHA
    75f4205 View commit details
    Browse the repository at this point in the history