Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(NODE-4133): array field NestedPaths return type #3184

Merged
merged 3 commits into from
Apr 5, 2022

Conversation

boenfu
Copy link
Contributor

@boenfu boenfu commented Mar 30, 2022

Description

What is changing?

before:
image
after:
image

Is there new documentation needed for these changes?

not need

What is the motivation for this change?

a tsc build error occurred for our specific requirements, after locating the cause several times, I think it is good for everyone, so fix it

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: <type>(NODE-xxxx)<!>: <description>
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@nbbeeken nbbeeken added the External Submission PR submitted from outside the team label Mar 30, 2022
@nbbeeken
Copy link
Contributor

Hi @boenfu thanks for catching this! I'm going to investigate if there's a way we can add a test for why this autocomplete did not work. If you have any ideas our typescript tests for the Filter can be found in test/types/community/collection/filterQuery.test-d.ts. But I'll update you if I find something.

cc: @baileympearson

@boenfu
Copy link
Contributor Author

boenfu commented Mar 31, 2022

Hi @boenfu thanks for catching this! I'm going to investigate if there's a way we can add a test for why this autocomplete did not work. If you have any ideas our typescript tests for the Filter can be found in test/types/community/collection/filterQuery.test-d.ts. But I'll update you if I find something.

cc: @baileympearson

Okey ~ I added two test cases to prove that the type hint was fixed.

The command npm run check:lint was failed before fix it.

image

Is there anything else I can help

src/mongo_types.ts Outdated Show resolved Hide resolved
@dariakp dariakp added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Apr 4, 2022
Copy link
Contributor

@baileympearson baileympearson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@baileympearson baileympearson added Team Review Needs review from team and removed External Submission PR submitted from outside the team labels Apr 5, 2022
@nbbeeken nbbeeken removed the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Apr 5, 2022
@baileympearson baileympearson added the External Submission PR submitted from outside the team label Apr 5, 2022
@nbbeeken nbbeeken changed the title fix: fix array field NestedPaths return type fix(NODE-4133): array field NestedPaths return type Apr 5, 2022
Copy link
Contributor

@nbbeeken nbbeeken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the testing! this LGTM
(I tried the fix locally in my VScode too, works)

@baileympearson baileympearson merged commit c46c984 into mongodb:main Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
External Submission PR submitted from outside the team Team Review Needs review from team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants