Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NODE-4133): array field NestedPaths return type #3184

Merged
merged 3 commits into from
Apr 5, 2022
Merged

fix(NODE-4133): array field NestedPaths return type #3184

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8a6cfa5
fix: fix array field NestedPaths return type
boenfu Mar 30, 2022
5ee8420
test: add missing array fields tests
boenfu Mar 31, 2022
64574d6
fix: fix nested paths for array field
boenfu Apr 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/mongo_types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -515,7 +515,7 @@ export type NestedPaths<Type> = Type extends
ArrayType extends Type
? [Key] // we have a recursive array union
: // child is an array, but it's not a recursive array
[Key, ...NestedPaths<Type[Key]>]
baileympearson marked this conversation as resolved.
Show resolved Hide resolved
[Key] | [Key, ...NestedPaths<Type[Key]>]
: // child is not structured the same as the parent
[Key, ...NestedPaths<Type[Key]>];
}[Extract<keyof Type, string>]
Expand Down
8 changes: 8 additions & 0 deletions test/types/community/collection/filterQuery.test-d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,6 +204,14 @@ expectNotType<Filter<PetModel>>({ 'playmates.0.name': 123 });
expectNotType<Filter<PetModel>>({ 'laps.foo': 'string' });
expectNotType<Filter<PetModel>>({ 'treats.0': 123 });

/// it should not accept wrong types for nested document array fields
expectError<Filter<PetModel>>({
treats: {
$elemMatch: true
}
});
expectError<Filter<PetModel>>({ treats: 123 });

// Nested arrays aren't checked
expectNotType<Filter<PetModel>>({ 'meta.deep.nestedArray.0': 'not a number' });

Expand Down