Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(NODE-4484): add experimental support for disambiguatedPaths in change stream documents #3365

Merged
merged 5 commits into from
Aug 23, 2022

Conversation

baileympearson
Copy link
Contributor

@baileympearson baileympearson commented Aug 17, 2022

Description

What is changing?

This PR is a POC PR for mongodb/specifications#1292.

A new field is supported on change stream update documents on servers >= 6.1.0 when showExpandedEvents is true. This PR adds new spec tests for the new field and documents the new property on the UpdateDescription type, marked as experimental.

A follow up ticket has been filed to remove the experimental tag after the 6.1 release - https://jira.mongodb.org/browse/NODE-4554.

Is there new documentation needed for these changes?

No.

What is the motivation for this change?

https://jira.mongodb.org/browse/DRIVERS-2344.

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: <type>(NODE-xxxx)<!>: <description>
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@baileympearson baileympearson force-pushed the NODE-4484-updateDescription-field-enhancement branch from eee0b08 to a065cfb Compare August 17, 2022 17:20
@baileympearson baileympearson changed the title test: add unified tests for disambiguatedPaths test(NODE-4484): add experimental support for disambiguatedPaths in change stream documents Aug 17, 2022
@baileympearson baileympearson marked this pull request as ready for review August 17, 2022 17:28
@durran durran added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Aug 17, 2022
@durran durran self-assigned this Aug 17, 2022
durran
durran previously approved these changes Aug 19, 2022
Copy link
Member

@durran durran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@durran durran added Team Review Needs review from team and removed Primary Review In Review with primary reviewer, not yet ready for team's eyes labels Aug 19, 2022
@durran durran removed their assignment Aug 19, 2022
@durran durran force-pushed the NODE-4484-updateDescription-field-enhancement branch from a4ab9ff to 565fd4f Compare August 19, 2022 02:47
durran
durran previously approved these changes Aug 19, 2022
@durran
Copy link
Member

durran commented Aug 19, 2022

CSFLE pinned commit tests will fail after the rebase of mongodb/libmongocrypt#443 - the sha1 doesn't exist anymore after the squash/rebase of that PR but does not affect this PR.

src/change_stream.ts Outdated Show resolved Hide resolved
@dariakp
Copy link
Contributor

dariakp commented Aug 22, 2022

@baileympearson Should this really be a "test" and not a "feat" commit? Experimental or not, it's still not a test-only commit. I also noticed a curious failure - a cursor exhausted test - has that been already investigated and logged a flaky issue?

@baileympearson baileympearson changed the title test(NODE-4484): add experimental support for disambiguatedPaths in change stream documents feat(NODE-4484): add experimental support for disambiguatedPaths in change stream documents Aug 22, 2022
@durran durran merged commit 846365a into main Aug 23, 2022
@durran durran deleted the NODE-4484-updateDescription-field-enhancement branch August 23, 2022 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team Review Needs review from team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants