Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop old Nodejs version support? #17

Closed
hasezoey opened this issue Jul 19, 2022 · 1 comment
Closed

Drop old Nodejs version support? #17

hasezoey opened this issue Jul 19, 2022 · 1 comment

Comments

@hasezoey
Copy link
Member

hasezoey commented Jul 19, 2022

Do you want to request a feature or report a bug?
discussion

What is the current behavior?
Currently the code seems to be made for newer version of nodejs, while a effort was made to be nodejs 4.x compatible, but did not reach everywhere (like stringToParts.js is still let/const), so maybe consider dropping old version of nodejs (either by matching what mongoose requires or something like nodejs 8)

PS: it also seems old version are not even tested anymore (lowest version i see is 12)

@vkarpov15
Copy link
Member

If memory serves, let and const work fine in Node 4 as long as you use strict mode. So that's not a problem.

But you're right that we should drop support for older versions of Node. No need to support anything below 12 these days. I'd like to do that before we ship a 1.0.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants