Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[converged] reduce nng thread counts #1711

Open
catfact opened this issue Oct 5, 2023 · 0 comments
Open

[converged] reduce nng thread counts #1711

catfact opened this issue Oct 5, 2023 · 0 comments

Comments

@catfact
Copy link
Collaborator

catfact commented Oct 5, 2023

re:
#1706 (comment)

i've forked the nng repo under monome and noted what appear to be the relevant vars in nng/CMakeLists.txt

set(NNG_MAX_TASKQ_THREADS 16 CACHE STRING "Upper bound on taskq threads, 0 for no limit")

set(NNG_MAX_EXPIRE_THREADS 8 CACHE STRING "Upper bound on expire threads, 0 for no limit")

my wonderings:

  • what would be a reasonable count guess? just one thread per task? (given our very simple 1peer <-> 1peer graph)
  • can we trigger a cmake build from waf if we submodule nng under third-party? if not then i guess this might better be moved to norns-image

also mostly out of curiousity: is having excess nng threads a significant / blocking issue? seems like if idle they wouldn't have too much impact

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant