This repository has been archived by the owner on Jun 25, 2024. It is now read-only.

Missing return statements after calls to result in SwiftMsalFlutterPlugin.swift #21

Open

lyleresnick opened this issue Sep 30, 2020 · 0 comments

lyleresnick commented Sep 30, 2020 •

edited

Loading

for example

at line 82, change:

      catch{
        result(FlutterError(code: "NO_ACCOUNT",  message: "Error retrieving an existing account", details: nil))
      }

to

      catch{
        result(FlutterError(code: "NO_ACCOUNT",  message: "Error retrieving an existing account", details: nil))
        return
      }

this code is only run when the keychain is not setup correctly and results in a crash

there are many other calls to result without returns following them

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.