Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.5 - MDL-82427 - Please rename your class to \filter_embedquestion\text_filter and move it to 'filter/embedquestion/classes/text_filter.php'. #31

Open
aspark21 opened this issue Sep 27, 2024 · 2 comments

Comments

@aspark21
Copy link

Moodle 4.5 (beta)
filter_embedquestion main
PHP8.1

Testing attempt detail view and delete feature/A teacher can see their students attempt summary in an activity
When I am on the "C1" "report_embedquestion > Progress report for Course" page logged in as "teacher1": debugging() message/s found:
Inclusion of filters from 'filter/embedquestion/filter.php' using the 'filter_embedquestion' class naming has been deprecated. Please rename your class to \filter_embedquestion\text_filter and move it to 'filter/embedquestion/classes/text_filter.php'. See MDL-82427 for more information.
line 147 of /filter/classes/filter_manager.php: call to debugging()
line 294 of /filter/classes/filter_manager.php: call to core_filters\filter_manager->make_filter_object()
line 1880 of /lib/pagelib.php: call to core_filters\filter_manager->setup_page_for_globally_available_filters()
line 108 of /lib/classes/output/bootstrap_renderer.php: call to moodle_page->initialise_theme_and_output()
line 1777 of /lib/formslib.php: call to core\output\bootstrap_renderer->__call()
line 212 of /lib/formslib.php: call to MoodleQuickForm->__construct()
line 133 of /report/embedquestion/classes/local/report/progress_report.php: call to moodleform->__construct()
line 66 of /report/embedquestion/index.php: call to report_embedquestion\local\report\progress_report->init()
 (Exception)
@rezeau
Copy link

rezeau commented Oct 30, 2024

Just confirming this issue (on Moodle 4.5)

@leonstr
Copy link

leonstr commented Nov 5, 2024

Pull request #33 with proposed fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants