Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Add ImagePullSecrets to a service account #20

Open
Vad1mo opened this issue Feb 27, 2021 · 0 comments
Open

Feature Request: Add ImagePullSecrets to a service account #20

Vad1mo opened this issue Feb 27, 2021 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@Vad1mo
Copy link

Vad1mo commented Feb 27, 2021

Besides creating secrets, the option to add imagePullSecrets to a service account would be a pleasant addition.

Example:

kind: HarborSync
metadata:
  name: my-project
spec:
  type: Regex
  name: "my-project" # <--- specify harbor project
  robotAccountSuffix: "k8s-sync-robot" # <--- should be unique per kind: HarborSync
  mapping:
  - type: Translate
    namespace: "team-a" # <--- target namespace
    secret: "my-project-pull-token" # <--- target secret name
  - type: Translate
    namespace: "team-b"
    secret: "my-project-pull-token"
    serviceaccount: default # <--- add the imagePullSecret to the service account 

We proxy all images and use external Helm Files the might refer to Docker Hub. ImagePullSecret on ServiceAccounts one doesn't need to change the deployment.

@moolen moolen added enhancement New feature or request good first issue Good for newcomers labels Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants