Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong placement of git bisect reset in file finder.sh #1

Open
helmutneukirchen opened this issue May 4, 2022 · 2 comments
Open

Wrong placement of git bisect reset in file finder.sh #1

helmutneukirchen opened this issue May 4, 2022 · 2 comments

Comments

@helmutneukirchen
Copy link

The git bisect reset needs to be made after the whole git bisect run has finished.

@morgaesis
Copy link
Owner

Do you mean for cleaning up after the git bisect run? If so, I just fixed it in 5406da6

@helmutneukirchen
Copy link
Author

The point is that all the bisect steps change the HEAD pointer, i.e. after the git bisect run having finished, the HEAD is not anymore where it was before the git bisect start. If you commit then changes, it commits it then to locations where you might not expect it. The git bisect restore sets the pointer to where it was when you used git bisect start which makes the finder script behave less surprising.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants