-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Factorize mul
, div
, weightedAvg
to minimize bytecode size
#77
Comments
In favor of this. Related to #57 |
As long as it improves readability while preserving gas efficiency I'm ok with that |
By the way, I don't think that it would change the bytecode size, but only the Solidity code size. |
I won't spend much time for now on this, given that I don't believe the compiler will be smart enough to compile to something as gas-efficient as the current implementation (because we need to abstract a I believe it requires ethereum/solidity#891 to be addressed first |
I didn't know that it wasn't possible to import a lib in a lib. So we are stuck with this... |
Should we close @Rubilmax ? |
I would like to see morpho-utils completely revamped to do general fixed point maths instead of Aave/Compound specific maths. In this case this could be implemented. Edit: with this naming 👌 |
This is just a random open-source idea that I think would benefit someone in the universe, but is blocked by a Solidity technical limit |
#66 (comment)
The text was updated successfully, but these errors were encountered: