Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parmed -> GMSO loses layered dihedrals #561

Open
rsdefever opened this issue Jun 25, 2021 · 1 comment · May be fixed by #569
Open

Parmed -> GMSO loses layered dihedrals #561

rsdefever opened this issue Jun 25, 2021 · 1 comment · May be fixed by #569
Assignees
Labels
bug Something isn't working conversions conversions of GMSO to and from other format

Comments

@rsdefever
Copy link
Member

If a parmed.Structure has multiple dihedral potentials for a single set of atoms, then this information is lost in the conversion to the gmso.Topology.

I have put together a gist with a simplified example:

import parmed
from gmso.external import from_parmed

pmd = parmed.load_file("emim_fake.top", xyz="emim.gro")
top = from_parmed(pmd)

print(top.dihedral_types)
print(pmd.dihedrals)
@rsdefever rsdefever added the bug Something isn't working label Jun 25, 2021
@umesh-timalsina
Copy link
Member

Inorder to keep the current API consistent, we can introduce two new concepts to be contained in GMSO topology:

  1. class LayeredDihedral: Subclasses gmso.Dihedral but has a list of dihedral types associated with it
  2. class LayeredImproper: Subclasses gmso.Improper but has a list of improper types associated with it

With these concepts, there are the following changes:

  1. Update Topology Methods
  2. get_index method

@umesh-timalsina umesh-timalsina linked a pull request Jul 13, 2021 that will close this issue
4 tasks
@daico007 daico007 added the conversions conversions of GMSO to and from other format label Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working conversions conversions of GMSO to and from other format
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants