Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increased auth performance #13

Open
goto3 opened this issue Jul 17, 2019 · 1 comment
Open

Increased auth performance #13

goto3 opened this issue Jul 17, 2019 · 1 comment

Comments

@goto3
Copy link

goto3 commented Jul 17, 2019

Hello, I am a starting with node.js and I found something interesting:

On auth file in routes folder I changed this on line 17:

const validPassword = await bcrypt.compare(req.body.password, user.password);
if (!validPassword) return res.status(400).send("Invalid email or password.");

image

to this:

await bcrypt.compare(req.body.password, user.password, function(err, result) {
    if (!result) return res.status(400).send("Invalid email or password.");
});

image

and decreased request processing time from 85 ms to 5 ms average.

Why is that?

Note: I am using bcrypt v3.0.6

Thank you very much

@rustemjantayev
Copy link

Because the request was cached. Try run different users ,and you will see.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants