Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Radio button should be removed if device contain single VC while sharing. #212

Closed
Anushree09-N opened this issue Nov 6, 2022 · 4 comments · Fixed by #253
Closed

Radio button should be removed if device contain single VC while sharing. #212

Anushree09-N opened this issue Nov 6, 2022 · 4 comments · Fixed by #253
Assignees
@Anuranjan14
Labels
beta_must_fix bug Something isn't working Minor triaged Triage completed
Milestone
Sprint-16 23 Nov 22

Comments

@Anushree09-N
Copy link

Describe the bug
Radio button should be removed if device contain single VC while sharing.

Prerequisite Download VC in sharing phone.

To Reproduce

  • unlock the app
  • Open qr code in requesting device.
  • Open scanner in sharing device and scan the qrcode
  • select VC to share

Current behavior
Even when device has single VC, while sharing radio button is added on VC for selection.

Expected behavior
Radio button should be removed if device contain single VC while sharing.

Screenshots
IMG_20221106_202615

Smartphone (please complete the following information):

  • Device: iPhone7 & iPhone XR
  • OS: 15.4.1
  • Inji app version: 0.4.0 (16) in test flight
  • MOSIP Version: 1.2.1
  • MOSIP server: qa-121.mosip.net

Additional context
Same issue is observed in cross platform sharing as well.
@Anushree09-N Anushree09-N added bug Something isn't working triage This issue is pending confirmation and planning and should not be worked on yet Minor labels Nov 6, 2022
@Sujithbn Sujithbn added triaged Triage completed and removed triage This issue is pending confirmation and planning and should not be worked on yet labels Nov 7, 2022
@Sujithbn Sujithbn added this to the Sprint-16 23 Nov 22 milestone Nov 8, 2022
@Sujithbn Sujithbn moved this to To do (under triage) in MOSIP Inji issues tracking Nov 8, 2022
@Anil-kumar-Majji
Copy link
Contributor

Anil-kumar-Majji commented Nov 14, 2022 •
edited
Loading

@rakhimosip @Anushree09-N The above Issue was fixed by removing the check-box react-native-element in singleItem.tsx module. Now radio button will be not there while sharing if, a single VC in the device and auto-selecting
Respective Screenshot

@Sujithbn Sujithbn moved this from To do (under triage) to Code review in MOSIP Inji issues tracking Nov 15, 2022
@Sujithbn Sujithbn linked a pull request Nov 15, 2022 that will close this issue
Radio button removed if device contain single VC while sharing. #253
Merged
@Sujithbn Sujithbn moved this from Code review to Merged in MOSIP Inji issues tracking Nov 23, 2022
@Sujithbn Sujithbn moved this from Merged to QA (test) in MOSIP Inji issues tracking Nov 23, 2022
@Anushree09-N
Copy link
Author

Verified on:

Device: iPhone 8 & iPhone 11
OS: 16.0.2 (20A380), 15.6.1
Inji app version: 0.4.1 (7) -> Testflight
MOSIP Version: 1.2.0.1
MOSIP server: qa5.mosip.net

Able to replicate the issue

image

@Anil-kumar-Majji
Copy link
Contributor

@Anushree09-N The above Issue was rectified, Raised and shared respective PR #392

@Sujithbn Sujithbn moved this from QA (test) to Code review in MOSIP Inji issues tracking Jan 9, 2023
@Anuranjan14
Copy link

Anuranjan14 commented Mar 23, 2023 •
edited
Loading

As per the latest design radio button is removed instead we have vc selection via green border on selected vc. Hence closed.
Attaching the screenshot for the reference:
image

CommitId:
image

@github-project-automation github-project-automation bot moved this from Code review to Merged in MOSIP Inji issues tracking Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Anuranjan14 Anuranjan14

Labels
beta_must_fix bug Something isn't working Minor triaged Triage completed
Projects
MOSIP Inji issues tracking
Status: Merged
Milestone
Sprint-16 23 Nov 22
Development

Successfully merging a pull request may close this issue.

Radio button removed if device contain single VC while sharing. Anil-kumar-Majji/inji_App
6 participants
@Anushree09-N @rakhimosip @srikanth716 @Anil-kumar-Majji @Sujithbn @Anuranjan14