Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: use linter to check UT #672

Open
2 tasks
seeflood opened this issue Jun 26, 2022 · 0 comments
Open
2 tasks

ci: use linter to check UT #672

seeflood opened this issue Jun 26, 2022 · 0 comments
Labels
help wanted Extra attention is needed kind/ci

Comments

@seeflood
Copy link
Member

What would you like to be added:
use linter to check UT, including:

  • check that every UT must have appropriate assertions. I don't know how to do it
    image

  • check that every UT must have appropriate case name. I don't know how to do it
    image

Why is this needed:
A stricter linter can make code review easier
@seeflood seeflood added help wanted Extra attention is needed kind/ci labels Jun 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed kind/ci
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@seeflood