Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use args[0] as ProxyCommand #134

Closed
skruppy opened this issue Mar 18, 2016 · 4 comments · Fixed by #135 or #137
Closed

Use args[0] as ProxyCommand #134

skruppy opened this issue Mar 18, 2016 · 4 comments · Fixed by #135 or #137
Assignees
Milestone

Comments

@skruppy
Copy link

skruppy commented Mar 18, 2016

When writing the ~/.ssh/config use args[0] (the actual name, the application was called with) for the ProxyCommand instead of the static asshBinary.

@moul moul self-assigned this Mar 21, 2016
@moul moul modified the milestone: v2.3.0 Mar 21, 2016
@moul
Copy link
Owner

moul commented Mar 21, 2016

sure, will do

@jedahan
Copy link

jedahan commented Mar 22, 2016

this is not working correctly for me - it is prepending the path from which I called assh, instead of the path of the assh binary

so if i am in /some/dir, it makes the config

/some/dir/assh instead of the same output as which ssh

@moul
Copy link
Owner

moul commented Mar 22, 2016

@jedahan, thank you,

I just removed the absolute path resolving so it now works with

  • absolute paths
  • direct binary call with correct $PATH

We just need to take care of never call something like cd /some/where; ./assh build > ~/.ssh/config which will generate ProxyCommand ./assh proxy --port=%p %h which will only works if ssh is called always from the same directory

@jedahan
Copy link

jedahan commented Mar 22, 2016

Thank you for the quick fix, and awesome software!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants