Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace boost constants #1373

Closed
7 tasks
henrygerardmoore opened this issue Jun 16, 2022 · 1 comment
Closed
7 tasks

Replace boost constants #1373

henrygerardmoore opened this issue Jun 16, 2022 · 1 comment

Comments

@henrygerardmoore
Copy link
Contributor

henrygerardmoore commented Jun 16, 2022

Background

When MoveIt2 is converted to the C++20 standard, it will be possible to remove the usage of boost::math::constants and replace them with the equivalent constants from std::numbers. See the constants listed here for more information. If you want to check, the C++ standard currently used can be seen here (if the link is dead, go to the moveit_package.cmake file in moveit2/moveit_common/cmake/). If this is still C++17 (there will be a line that says set(CMAKE_CXX_STANDARD 17)) then this task cannot be completed yet.

This issue follows from #1372 and #1331 in incrementally removing the usage of boost from the MoveIt codebase.

Instructions

Hi, this is a first-timer-only issue. This means we've worked to make it more legible to people who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

We're interested in helping you take the first step, and can answer questions and help you out along the way. Note that we're especially interested in contributions from underrepresented groups!

We know that creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this PR for someone new, and looking through our general bug issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

📋 Step by Step

  • 🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!

  • 🗄️ Create a local workspace for making your changes and testing following these instructions

  • 🍴 Fork the repository using the handy button at the top of the repository page and clone it into ~/ws_moveit/src/moveit, here is a guide that you can follow (You will have to remove or empty the existing moveit folder before cloning your own fork)

  • 🤖 Apply clang-format-10 auto formatting, following these instructions

  • 💾 Commit and Push your changes

  • 🔀 Start a Pull Request to request to merge your code into master. There are two ways that you can start a pull request:

  1. If you are not familiar with GitHub or how to create a pull request, here is a guide you can follow on how GitHub works.
  2. If you are familiar with the terminal or would like to learn to use it, here is a great tutorial on how to send a pull request using the terminal.
  • 🏁 Done Ask in comments for a review :)

Is someone else already working on this?

🔗- We encourage contributors to link to the original issue in their pull request so all users can easily see if someone's already started on it.

👥- If someone seems stuck, offer them some help!

🤔❓ Questions?

Don’t hesitate to ask questions or to get help if you feel like you are getting stuck. For example leave a comment below!
Furthermore, you find helpful resources here:

Good luck with your first issue!

@henrygerardmoore
Copy link
Contributor Author

henrygerardmoore commented Jun 17, 2022

Oops, will be closed in #1372 as math.h also includes pi.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant