Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MoveItPy only supports a single set of parameters #2219

Closed
henningkayser opened this issue Jun 1, 2023 · 0 comments · Fixed by #2393
Closed

MoveItPy only supports a single set of parameters #2219

henningkayser opened this issue Jun 1, 2023 · 0 comments · Fixed by #2393
Assignees
Labels
bug Something isn't working persistent Allows issues to remain open without automatic stalling and closing.

Comments

@henningkayser
Copy link
Member

henningkayser commented Jun 1, 2023

Description

MoveItPy parses the --param-file arg at constructions here, ignoring that there can be multiple.
This is the case when multiple dictionaries are listed as launch parameters, as for example here with RViz.

I ran into this when trying to pass use_sim_time:=true to moveit_py which always failed, even though MoveGroup/MoveItCpp didn't have any issues with that. The additional parameters where simply ignored. Side note, the temporary parameter files are being added to /tmp/, the actual file names are listed in the ROS log.

Your environment

  • ROS Distro: Humble
  • OS Version: Ubuntu 22.04
  • jammy-humble binaries (main branch)

Steps to reproduce

Add {use_sim_time:=True} to the moveit_py parameters, then query ros2 param get moveit_py use_sim_time (it's False).

Expected behaviour

All passed parameters should be forwarded to MoveItCpp.

Actual behaviour

All parameters that are not in the first dict are ignored by moveit_py.

@henningkayser henningkayser added the bug Something isn't working label Jun 1, 2023
@sjahr sjahr added the persistent Allows issues to remain open without automatic stalling and closing. label Jul 12, 2023
@henningkayser henningkayser linked a pull request Oct 10, 2023 that will close this issue
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working persistent Allows issues to remain open without automatic stalling and closing.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants